Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added github-handle for Amanda Glover on VRMS Project Page #7560

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Added github-handle for Amanda Glover on VRMS Project Page #7560

merged 1 commit into from
Oct 6, 2024

Conversation

floydferrer
Copy link
Member

Fixes #7355

What changes did you make?

  • Added github-handle for Amanda Glover within leadership variable on VRMS Project Page

Why did you make the changes (we will use this info to test)?

  • github-handle will eventually replace the github and picture variables, reducing the redundancy in the project file.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b floydferrer-add-github-handle-for-amanda-glover-7355 gh-pages
git pull https://github.com/floydferrer/website.git add-github-handle-for-amanda-glover-7355

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 4, 2024
@codyyjxn codyyjxn self-requested a review October 4, 2024 16:39
@codyyjxn
Copy link
Member

codyyjxn commented Oct 4, 2024

Availability: M>F
ETA: EOD

codyyjxn
codyyjxn approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@codyyjxn codyyjxn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@floydferrer Good Job on your first good issue.

  • The branch name is correct with the issue as well.
  • The issue is linked correctly
  • The title is clear and concise.

Thank you for your contribution !

@patelbansi3009 patelbansi3009 self-requested a review October 5, 2024 22:39
@patelbansi3009
Copy link
Member

Availability: Monday - Friday (9 am - 6 pm)(EST)
ETA: EOD

patelbansi3009
patelbansi3009 approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@patelbansi3009 patelbansi3009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job @floydferrer !

  • Used the correct branch for the pull request
  • Linked the issue correctly
  • Made the changes as requested in the issue
  • Made no visual changes on the website
  • Spaces were used instead of tabs

Keep up the good work! Thank you for your contribution. 👍

@t-will-gillis t-will-gillis merged commit c88687b into hackforla:gh-pages Oct 6, 2024
7 checks passed
@floydferrer floydferrer mentioned this pull request Oct 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patelbansi3009 patelbansi3009 patelbansi3009 approved these changes

@codyyjxn codyyjxn codyyjxn approved these changes

Assignees
No one assigned
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add github-handle for Amanda Glover in vrms.md
4 participants
@floydferrer @codyyjxn @patelbansi3009 @t-will-gillis